#226
- Created on2014-04-22 17:46
- Reported by
- StatusNew
- PriorityNormal (3)
- Assigned to
- Milestone-
- Plan Level-
- Due Date-
paex_ocean_shore uses private API: PaUtil_AllocateMemory
Confusion ensues:
http://stackoverflow.com/questions/22616016/why-should-i-use-pautil-allocatememory-instead-of-malloc/23226628#23226628
The examples shouldn't be using private APIs. Only those functions in portaudio.h should be used in examples.
PaUtil_AllocateMemory is not an exported symbol.
That example is also using the ring buffer code too (!). I'm not sure whether it should be an example if it uses private APIs like this.
At the minimum it should be very clearly documented that this is an example of using the ring buffer code, and I don't think there is a reason to use PaUtil_AllocateMemory over malloc().
http://stackoverflow.com/questions/22616016/why-should-i-use-pautil-allocatememory-instead-of-malloc/23226628#23226628
The examples shouldn't be using private APIs. Only those functions in portaudio.h should be used in examples.
PaUtil_AllocateMemory is not an exported symbol.
That example is also using the ring buffer code too (!). I'm not sure whether it should be an example if it uses private APIs like this.
At the minimum it should be very clearly documented that this is an example of using the ring buffer code, and I don't think there is a reason to use PaUtil_AllocateMemory over malloc().
Leave a comment
You are utterly and entirely correct, I thought the text in the brief would be enough but now that I read it again it can definitely be taken as a valid example of the public API, which of course it was not meant to be. I'll update the text to reflect this, and also to point out that in order for the code to work, you need static linking to PA.
I'm also for removing it or moving it to some other location in SVN.
I'm also for removing it or moving it to some other location in SVN.