file:bJO152Lxir458hacwqjQYw

WMME has now been patched in trunk r1925. https://www.assembla.com/code/portaudio/subversion/changesets/1925

The following WMME functions that deal with strings are still broken: PA_MME_SET_LAST_WAVEIN_ERROR, PA_MME_SET_LAST_WAVEOUT_ERROR, PaMme_SetLastSystemError

DirectSound has now been patched in trunk r1927. https://www.assembla.com/code/portaudio/subversion/changesets/1927

Note that DirectSound doesn't have the same problem with UNICODE error strings that WMME does, because DirectSound currently has no error string handling whatsoever(!)

The applied patches use the ANSI code page when the "_UNICODE" symbol is not defined. The WMME patch just copies windows strings directly with strcpy(), and the DirectSound patch converts the string from unicode to the ANSI code page. This doesn't seem right.

My understanding is that we have specified the PortAudio string encoding to always use UTF8. That means that if PA gets an ANSI code page string from a non-unicode Windows API, it should convert it to UTF8.

If that is the case I need to make another patch that converts Windows 8-bit strings from the ANSI code page to UTF8.

Does that seem right?

Yes, I think so, since Windows 8-bit strings (or multibyte strings) are not UTF-8, a conversion would be needed in this case also. In WDM-KS I handle this by always using the Wide version of Win32 API functions, regardless of _UNICODE being defined or not, that way I only have to handle Unicode -> UTF-8 encoding.