Clean up CometListenee/CometListener/LocalSetupAndShutdown traits
On Fri, Dec 24, 2010 at 8:36 AM, Derek Chen-Becker <dchenbecker@gmail.com> wrote:
As part of my current work project I'm doing an overhaul of the Comet API docs and having just started I've already found some things that I think we might be able to clean up:
Yeah... you couldn't call super on a self-type, so I needed the marker.
Sounds good.
On a related note, now that we're strictly on 2.8+ for future releases, I was thinking it would be nice to standardize on a deprecation warning format. Something like "Post-<version> : <message>". That would allow us to report on deprecations for various versions, and would simplify identifying deprecated code for removal later.
Sounds great. Please write up a wiki page on this format.
As part of my current work project I'm doing an overhaul of the Comet API docs and having just started I've already found some things that I think we might be able to clean up:
- LocalSetupAndShutdown - This looks like it was intended to be a marker trait, or possibly to work around some issue with stackable traits in scala < 2.8. If I remove it completely everything appears to continue working fine
Yeah... you couldn't call super on a self-type, so I needed the marker.
- CometListener - This appears to just be an alias to CometListenee. Since comet actors work with ListenerManagers, I think it would make more sense to make the real trait CometListener and make CometListenee a deprecated alias
Sounds good.
On a related note, now that we're strictly on 2.8+ for future releases, I was thinking it would be nice to standardize on a deprecation warning format. Something like "Post-<version> : <message>". That would allow us to report on deprecations for various versions, and would simplify identifying deprecated code for removal later.
Sounds great. Please write up a wiki page on this format.
Leave a comment
on 2010-12-28 16:25 *
By Anonymous
Status changed from Accepted to Fixed
Work remaining changed from 3.0 to 0.0
(In revision:6265a978513df86c1c381ffc944a0ebdeba1c2eb) Added docs and remove unused trait from CometActor
Closes #803
Branch: master
Closes #803
Branch: master