#363
  • Created on
    2010-02-23 10:49
  • Reported by
    marius.danciu
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    marius.danciu
  • Milestone
    Lift 2.0-M3
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

LiftRules.jQueryVersion should not be there.

Details are described here: http://groups.google.com/group/liftweb/browse_thread/thread/807a9397f1e3fa9?hl=en_US

LiftRules should not have JQuery specific API's. JsArtifacts can/should cope with script versioning.
User picture
  on 2010-02-24 07:34 *
By marius.danciu
This is on review board.
User picture
  on 2010-02-24 18:59 *
By marius.danciu
Status changed from Accepted to Fixed
Fixed
User picture
  on 2010-02-28 21:27 *
By Indrajit Raychaudhuri
Status changed from Fixed to New
According to convention, JQuery14Artifacts should actually refer to the compressed version of jquery-1.4.2 min that is generated by yuicompressor-maven-plugin (and not minified version available for download).

Thus:
1. JQuery14Artifacts should refer to jquery-1.4.2-min.js instead of jquery-1.4.2.min.js
2. resources/toserve should include the uncompressed version jquery-1.4.2.js
User picture
  on 2010-02-28 21:42 *
By marius.danciu
According to what convension ?

for #2 why should we include the uncompressed version ?
User picture
  on 2010-02-28 21:49 *
By Indrajit Raychaudhuri
Status changed from New to Fixed
Ok, per quick chat with Marius, let's take this up on a separate thread.