Forget it: two columns revision (it is better)

Updating tickets (#517, #582, #584, #608, #614, #628, #629, #637, #638, #764, #784)

Updating tickets (#68, #69, #70, #71, #72, #73, #74, #75, #76, #130, #132, #134, #136, #137, #138, #131, #221, #247, #248, #242, #294)

Changing component

@debianus I started testing tonight. Testing with update of existing install. No changes have been made to the default page.

• When I click on the "History" button, the Original, Changed, Differences cells show at the top of the page and the page content shows below, without any comparisons. Would it be best to only show the column headers when a compare is actually being done?
• When I click on the "Compare" link for the only revision for that page, the content is loaded into all 3 columns. There shouldn't be any differences, but the 'Differences' column has content that is different than Original and Changed. It does this for a brand new page, too
• After making changes to a page and comparing, the new revision differences does appear to be working correctly, even when there are more than 2 revisions you could compare - nice work!

Thanks for testing @Steve Kenow

1. It was my fault. <{$swiki.body}> remains in wiwimod_history.html although it was deleted in index.php file.
2. Right. In trunk only body text is in the page. However History button only must to be when there are two or more revisions of a page. No sense when only there is one revision (history when there is no "history"). But I have no idea about how case diff in index.php works only in that case. And for me there is no differences between Original and changed if the body is the same, look (screenshot). However the matter is: history only when there is history screenshot
3. Thanks. I believe with these changes check revisions working fine (old diff code was from 2003). Only remains get a solution about History matter when only one revision is available.

To only show the History button when there is more than 1 revision available, we'll need another query to count them. The revisions property is just a counter to show how many times the page was updated, not how many active revisions there are for a page. The actual number and IDs of the revisions are not needed on a normal page load, so the list of revisions is not retrieved until then.

We could check when the history page loads and adjust the output based on having more than 1 revision to compare, since the query already runs for that page. This is the easiest and has no impact on current performance.

What do you think?

1.- I did not understand your point rightly. Yes, doing click in History button table for show changes must not be in the page; only when clicking in Compare link. I have solved the issue .
2.- I have got block Compare button when only revision is available.

$hist = $pageObj->history();
		$revisiones = count($hist);
		$xoopsTpl->assign('rev', $revisiones);

and only when rev >1 History button is in the page.
Is it ok for performance and page load?

Yes - in the section of index.php, after line 361, add the last 2 lines you showed.
$revisiones = count($hist); $xoopsTpl->assign('rev', $revisiones);

No added queries.

I looked at your commit - you added the count for history in the default view, which does add an extra query for every page view. If you put in the history/diff section of index.php - the lines I mentioned above - no extra queries on any page, but the history button would always appear.

Maybe we take another approach - after a page has more than 1 revision, we always leave at least 2 revisions. The cleanPagesHistory() and fix() need to be improved, anyway. Then, we can just check the value of the page revisions property without any extra queries and only show the History button when there are at least 2 revisions to compare.

So, in index.php. add something similar to my suggested changes. Then, you can use the smarty var $swiki.revisions in the template to test for more than 1 revision.

All right. The idea is move the code from default case to diff case, isn´t it?