Fix 'Poll received unknown value' wrong byte count
Posted by heyu_users on 2011-07-08 06:13
If it ever happens that a broken sequence, other than an incoming powerline signal, is fetched from the Heyu spool file by the engine or monitor, the check4poll() function puts all 0xff bytes collected so far back to the buffer and passes them, together with the following byte, for being reported with the "Poll received unknown value ..." error message. However, while doing this, the actual length of the broken sequence is not set, moreover with the variable expected to carry the length being used meanwhile for temporary storing the last byte value. As a result, the "Poll received unknown value ..." messages provide incorrect sequence lengths if different from 1 byte.
Thanks,
Janusz
Thanks,
Janusz
Home / Developer API / Tour / Get a Project - Solutions for Bug & Issue Tracking, Collaboration Tools, Subversion Hosting, Git Hosting
X10 automation for linux, unix, and mac os x is powered by Assembla.
1 Comments
By Janusz Krzysztofik on 2011-07-09 23:33
A new patch against the stable branch (v2.9.3) is available for on-line review or download. Comments and test reports are welcome.
While this bug doesn't affect Heyu ability to recognise and interpret the spool file contents correctly, it makes it harder to diagnose other problems, either hardware related or caused by other bugs, which exhibit themselves with "Poll received unknown value ..." reports. This issue has just been discovered while hunting for such other bugs (see ticket #10).
Thanks,
Janusz