#190
  • Created on
    2008-12-03 14:57
  • Reported by
    Vlad Dumitrescu
  • Status
    Fixed
  • Priority
    High (2)
  • Assigned to
    jakobc
  • Milestone
    0.5
  • Plan Level
    -
  • Permission type
    None
  • Estimate
    None/Small/Medium/Large None
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

indentation not completely ok

This is in 0.4.2.1.

scan_atom(Cs, Name, Toks, Pos, State, Errors) ->
    case catch list_to_atom(Name) of
    Atom when atom(Atom) ->
        Val = case reserved_word(Atom) of
              true ->
              {Atom, {Pos, length(Name)}};
              false ->
              {atom, {Pos, length(Name)}, Atom}
          end,
        scan(Cs, [], [Val|Toks], inc(Pos, length(Name)), State, Errors);
    _ ->
        scan(Cs, [], Toks, Pos, State, [{{illegal,atom},Pos}|Errors])
    end.

I believe it should be
scan_atom(Cs, Name, Toks, Pos, State, Errors) ->
    case catch list_to_atom(Name) of
      Atom when atom(Atom) ->
        Val = case reserved_word(Atom) of
              true ->
                {Atom, {Pos, length(Name)}};
              false ->
                {atom, {Pos, length(Name)}, Atom}
          end,
        scan(Cs, [], [Val|Toks], inc(Pos, length(Name)), State, Errors);
      _ ->
        scan(Cs, [], Toks, Pos, State, [{{illegal,atom},Pos}|Errors])
    end.
User picture
  on 2008-12-03 14:57 *
By Vlad Dumitrescu
(Comment removed)
User picture
  on 2008-12-03 14:59 *
By Vlad Dumitrescu
Description changed from This is in 0.4.2.1 scan_... to This is in 0.4.2.1.
Description changed from This is in 0.4.2.1 scan_... to This is in 0.4.2.1.
User picture
  on 2008-12-12 17:50 *
By jakobc
Works in 0.4.2.6 (and 0.4.2.1 too?)
User picture
  on 2008-12-12 17:50 *
By jakobc
Assigned to set to jakobc
Component changed from None to core
Milestone set to 0.4.3
Assigned to set to jakobc
Component changed from None to core
Milestone set to 0.4.3
User picture
  on 2009-02-19 13:05 *
By jakobc
Milestone changed from backlog to 0.5
Priority changed from Normal (3) to High (2)
Status changed from New to Accepted
Milestone changed from backlog to 0.5
Priority changed from Normal (3) to High (2)
Status changed from New to Accepted
still bad indentation of try/catch/end
User picture
  on 2009-02-27 21:09 *
By jakobc
Status changed from Accepted to Test
Status changed from Accepted to Test
User picture
  on 2009-03-04 14:29 *
By Vlad Dumitrescu
Status changed from Test to Fixed
Status changed from Test to Fixed
Updating tickets (#258, #260, #275, #91, #122, #190, #209, #246, #251, #127, #167, #180, #184, #187, #212, #230, #267, #105)