#63
  • Created on
    2010-01-26 13:39
  • Reported by
    bpsm
  • Status
    Invalid
  • Priority
    Normal (3)
  • Assigned to
    stuart.halloway
  • Milestone
    Release 1.2
  • Plan Level
    -
  • Permission type
    None
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

duck-streams open as resource what isn't File or URL

Currently: When duck-streams is given a string, it attempts to open it for reading as a URL and if that fails it tries the string as a path specifying a File. When the string doesn't specify a readable file either, we fail.

I'd like to see duck-streams try to resolve the string as a resource name before finally giving up.
User picture
  on 2010-01-30 19:33 *
By stuartsierra
Milestone set to Backlog
Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)
User picture
  on 2010-04-13 05:16 *
By stuart.halloway
Assigned to set to stuart.halloway
Milestone changed from Backlog to Release 1.2
User picture
  on 2010-04-13 08:21 *
By stuart.halloway
Status changed from New to Invalid
I am going to reject this patch for now, because I don't like:

  1. the double-purposing of filelike names. If a "foo/bar" points to something on the classpath, and something different on the filesystem, which one should dominate?
  2. the asymmetry with writing: you can't write to things on the classpath, so writer and reader would become asymmetric.

Better IMO just to be explicit about hitting the classpath.
User picture
  on 2010-04-13 09:05 *
By bpsm
Fair enough. The overloaded meaning of 'path-like-string' isn't pretty. As an alternative, perhaps you would consider including:
(defn #^URL resource
  "Return the URL of the named resource on the CLASSPATH.
nil indicates no such resource was found."
  [#^String name]
  (.getResource (clojure.lang.RT/baseLoader) name))

This would allow formulations like:
(input-stream (resource "foo/bar.gif"))

or even:
(-?> "foo/bar.gif" resource input-stream)

Which is reasonably compact and makes the meaning of the string clear.