#55
  • Created on
    2009-12-31 23:21
  • Reported by
    rnewman
  • Status
    Accepted
  • Priority
    Normal (3)
  • Assigned to
    Steve Gilardi
  • Milestone
    Backlog
  • Plan Level
    -
  • Permission type
    None
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

clojure.contrib.sql expects *err* to be a PrintWriter

The problem is that c.c.sql.internal calls `.println` on a "stream" to print update counts and errors. That method only exists on a `PrintWriter`. This isn't true within Slime, where it's a `StringWriter`.

The attached patch binds `*out*` and uses `println` instead, which does the right thing. I've augmented the docstrings to request a `Writer` as the value of `stream`, which aligns with the docstring for `print`.
User picture
  on 2009-12-31 23:22 *
By rnewman
Attachment sql-internal.diff added
file:btl6lW9Mmr3OPceJe5aVNr: Diff against current head.
User picture
  on 2010-01-31 03:33 *
By stuartsierra
Milestone set to Backlog
Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)
User picture
  on 2010-03-06 16:19 *
By Steve Gilardi
Status changed from New to Accepted
Following the discussion in the developer group and as suggested by Stuart Halloway, I'm planning to make these changes:

[1] adopt the substance of Richard Newman's patch, changes to sql.internal's print-sql-exception, print-sql-exception-chain, print-update-counts functions
[2] remove the automatic printing to err on exceptions. It will be up to the caller to handle the exceptions as he desires: eating, logging, or printing, etc.
[3] move the print* functions to c.c.sql proper as they will now be "public".