#35
  • Created on
    2009-10-10 00:52
  • Reported by
    Baishampayan Ghose
  • Status
    Test
  • Priority
    Normal (3)
  • Assigned to
    -
  • Milestone
    Backlog
  • Plan Level
    -
  • Permission type
    Private
  • Due Date
    -

Related Tickets

Add new subtask or bug

clojure.contrib.trace/deftrace does not work with function definitions with doc-strings

Apparently, defttrace does not support functions with doc-strings. I tried replacing defn with deftrace in a function of mine (as the docs indicated) and I got the following error -


java.lang.IllegalArgumentException: Don't know how to create ISeq from: Symbol


Sample code to reproduce the error -

(deftrace fact
  "Calculate the factorial of x"
  [x]
  (if (< x 1)
    1
    (* x (fact (- x 1)))))


Would be great if this bug is fixed, all my functions have doc-strings :)
User picture
  on 2010-01-31 09:03 *
By stuartsierra
Milestone set to Backlog
Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)
User picture
  on 2010-10-28 07:10 *
By trptcolin
Attachment 0001-Allow-deftrace-to-work-with-docstrings-and-metadata-.patch added
file:bns8Fu4Jqr37_9eJe5cbCb
User picture
  on 2010-10-28 07:16 *
By trptcolin
Status changed from New to Test
This patch adds support and tests for both docstrings and metadata, and also fixes the regex in the existing test to correctly identify errors. The current regex has unescaped characters: | ( ) that were almost certainly typos, as matching (for instance) only the last line of output would pass the test. The docstring/metadata support is a simplified version of what's in the source of defn.