Commits and tickets
Posted by kirill.krinkin on 2011-04-04 01:02
Guys,
it's quite strange for me when you push some code without referring to the tickets. For example https://www.assembla.com/code/cg-earth/git/changesets/89b37b31b3952a73b87a638c6d11e332550e8312 and lots of others. I really don't understand why we need such commits, which problem they are resolve. So, I cant figure out why we need this efforts.
One more example: https://www.assembla.com/code/cg-earth/git/changesets/89b37b31b3952a73b87a638c6d11e332550e8312 Why we need memory management refactoring? Why we don't use existing model? Why we cannot use Qt QObject model?? Do we really need a bicycle with square wheels? How should I analyse your code if I have no idea about goal of code?
it's quite strange for me when you push some code without referring to the tickets. For example https://www.assembla.com/code/cg-earth/git/changesets/89b37b31b3952a73b87a638c6d11e332550e8312 and lots of others. I really don't understand why we need such commits, which problem they are resolve. So, I cant figure out why we need this efforts.
One more example: https://www.assembla.com/code/cg-earth/git/changesets/89b37b31b3952a73b87a638c6d11e332550e8312 Why we need memory management refactoring? Why we don't use existing model? Why we cannot use Qt QObject model?? Do we really need a bicycle with square wheels? How should I analyse your code if I have no idea about goal of code?
Home / Developer API / Tour / Get a Project - Solutions for Bug & Issue Tracking, Collaboration Tools, Subversion Hosting, Git Hosting
Cg earth is powered by Assembla.
1 Comments
By AM5800 on 2011-04-04 09:15
Кстати, вопрос. Если я уже реализовал какую-то важную вещь, есть смысл создавать для этого тикет и закрывать его? Коммитить то часто я привык, а вот тикеты создавать - еще нет.
Насчет memory management - очередное громкое название от меня. Не более