#1249
  • Created on
    2011-10-03 06:17
  • Reported by
    Havoc Pennington
  • Status
    Invalid
  • Priority
    Normal (3)
  • Assigned to
    -
  • Milestone
    2.0-M1
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

AMQP: Avoid deluge of stack traces on errors

Two errors I encountered resulted in an enormous number of stack traces, destroying the utility of the logs and making it hard to understand what was wrong.

  • broker is not present; for example if you forgot to start it, or if you need to restart it.
  • RPC peer is not present (missing queue); for example, if it didn't start yet

these are both very common, since you may need to restart the broker or peer, and if you have two processes, they have to start in some order so one of them won't see the other yet. On some deployment setups you might not be able to control the order of startup.

If a broker is missing I would say you should get one log message (probably no trace; this isn't an exceptional condition or bug really). Then another log message when it reappears.
Similarly if a queue is missing with RPC, it should just automatically wait for the queue, logging only once.

The worst aspect of the tons of traces in the logs is that it isn't really clear from them what the problem is. It'd be much more useful if it just said "can't connect to broker"
User picture
  on 2011-10-03 06:45 *
By Jonas Bonér
Milestone set to 2.0
Updating tickets (#1244, #1246, #1249, #1250, #1251, #1252, #1255)
User picture
  on 2011-10-07 06:41 *
By viktorklang
Summary changed from Avoid deluge of stack traces on errors to AMQP: Avoid deluge of stack traces on errors
User picture
  on 2011-11-22 08:45 *
By viktorklang
Status changed from New to Invalid
Updating tickets (#980, #1217, #1244, #1246, #1249, #1250, #1251, #1302)

AMQP should have a full overhaul.
User picture
  on 2011-12-14 16:49 *
By viktorklang
Milestone changed from 2.0 to 2.0-M1
Updating tickets (#1129, #1132, #1138, #1149, #1153, #1154, #1157, #1161, #1163, #1168, #1170, #1171, #1172, #1176, #1177, #1178, #1180, #1199, #1217, #1218, #1219, #1237, #1238, #1239, #1244, #1246, #1249, #1250, #1251, #1252, #1256, #1301, #1302, #1306, #1395, #1396, #1409, #1418, #455, #891, #895, #912, #956, #972, #1031, #1374, #880, #1125, #1146)