Comments on commits
on 2014-11-15 18:00
By skenow
view inline at modules/wiwimod/tasks/462_recent_pages_block/language/english/blocks.php (commit 25341)
on 2014-11-15 17:59
By skenow
view inline at modules/wiwimod/tasks/462_recent_pages_block/blocks/wiwimod_recent.php (commit 25341)
114 |
{ |
For some options you have the value = 0 being set as checked, but for other value=1 is checked. Is this correct, @debianus? |
|
115 |
$form .= 'checked="checked"'; |
on 2014-11-15 17:58
By skenow
view inline at modules/wiwimod/tasks/462_recent_pages_block/templates/blocks/wiwimod_recent.html (commit 25341)
18 |
<span class="itemPoster"><{if $link.user}><{$link.user}><{/if}></span> |
I recommend moving the spans inside the {if } to prevent empty spans in the HTML |
|
19 |
<span class="itemPostDate"><{if $link.lastmodified}><{$link.lastmodified}><{/if}></span> |
on 2014-11-15 17:57
By skenow
view inline at modules/wiwimod/tasks/462_recent_pages_block/blocks/wiwimod_recent.php (commit 25341)
120 |
/* |
@debianus - Id this block for SimplyWiki? I don't see any other references for it. |
|
121 |
$modversion['blocks'][] = array( |
on 2012-11-08 09:55
By David Janssens
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/24695?comment_id=267393 (commit 24695)
Next time, instead of creating a new theme from scratch, could you please update the existing icmsbootstrap theme? Thanks!
on 2012-10-17 11:04
By David Janssens
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/24635?comment_id=246333 (commit 24635)
Thank you for the fix! Really appreciate it.
on 2012-07-27 07:49
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/24325?comment_id=183423 (commit 24325)
See the discussion in the forum here: http://community.impresscms.org/modules/newbb/viewtopic.php?topic_id=4905&viewmode=flat&order=ASC&type=&mode=0&start=20
on 2012-04-06 09:54
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/24003?comment_id=123393 (commit 24003)
Be careful with HTML5. It's not an official standard yet, because it's still under developmet.
on 2012-04-06 07:20
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/24003?comment_id=123383 (commit 24003)
Think you have to apply this to the css and other files too or not?
on 2012-03-27 02:39
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23959?comment_id=115943 (commit 23959)
I still don't see the background in IE9. The background is white.
When I click the Compatibility button I see the background, but than the tables are meshed up.
Think it's better to use the old css code and add 'max-height: 21px;' to the styles. Maybe set the font-size to a fixed value too.
When I click the Compatibility button I see the background, but than the tables are meshed up.
Think it's better to use the old css code and add 'max-height: 21px;' to the styles. Maybe set the font-size to a fixed value too.
on 2012-03-23 19:07
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23945?comment_id=113873 (commit 23945)
This doesn't work with IE !! All backgrounds are gone.
on 2012-03-16 07:23
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23867?comment_id=109693 (commit 23867)
Sorry, my mistake. Now I see the problem. ;-)
Will check other wflinks-based modules for this issue and mention the fix in the changelog.
I am wondering if the div-tags are really needed, don't think so.
Many thanks!
Will check other wflinks-based modules for this issue and mention the fix in the changelog.
I am wondering if the div-tags are really needed, don't think so.
Many thanks!
on 2012-03-16 03:32
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23867?comment_id=109423 (commit 23867)
Can you explain the unclosed a-tag, because I don't see it?
When disabling Comments in the Preferences this fix results to an empty div:
When disabling Comments in the Preferences this fix results to an empty div:
<!-- start comments loop -->
<div>
</div>
<!-- end comments loop -->
on 2012-02-03 10:23
By phoenyx
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23354?comment_id=86633 (commit 23354)
You should be using the constant ICMS_IMAGES_SET_URL.
on 2012-01-23 11:43
By qm-b
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23232?comment_id=80333 (commit 23232)
Thanks, I have adjusted the paths now.
on 2012-01-23 11:09
By phoenyx
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23232?comment_id=80313 (commit 23232)
Please note that this should go into a folder called "releases", not "tag".
on 2012-01-18 21:49
By skenow
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23198?comment_id=78313 (commit 23198)
It would be simpler to have done
It looks like your path is changed, somewhat - in the constructor,
in the method
the path is missing 'indeximages'
icms_core_Filesystem::mkdir($dir, 0777, '');
It looks like your path is changed, somewhat - in the constructor,
$this->_uploadPath = ICMS_ROOT_PATH . '/uploads/' . basename(dirname(dirname(__FILE__))) . '/indeximages/';
in the method
public function getImagePath() {
$dir = $this->_uploadPath;
if (!file_exists($dir)) {
$moddir = basename(dirname(dirname(__FILE__)));
icms_core_Filesystem::mkdir($dir, "0777", ICMS_ROOT_PATH . '/uploads/' . $moddir . '/' );
}
return $dir . "/";
}
the path is missing 'indeximages'
on 2012-01-17 11:24
By phoenyx
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23178?comment_id=77213 (commit 23178)
See my other comment on commit 11521. I definitly don't think that this code should be here.
on 2012-01-13 04:03
By phoenyx
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23148?comment_id=75983 (commit 23148)
You might want to remove the eclipse files?
on 2011-12-22 11:22
By phoenyx
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23083?comment_id=70663 (commit 23083)
Never mind. The commit was already reverted by sato-san.
on 2011-12-22 11:20
By phoenyx
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23083?comment_id=70653 (commit 23083)
Would you please undo this commit? You've overwritten the English language files instead of creating German language files in http://www.assembla.com/code/impresscmsaddons/subversion/nodes/languages/german/modules/news_ipf
on 2011-11-21 02:38
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23004?comment_id=54873 (commit 23004)
PS. We still need to find a way to have multilanguage support for the SSP. Currently it supports German only.
on 2011-11-21 02:37
By mcdonald3072
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/23004?comment_id=54863 (commit 23004)
Thanks for this fix!
Changing overflow:auto into display:inline-block can result in stretching the article over the blocks at the right when the article contains an image with a width greater than the width of the center column in the browser window.
Changing overflow:auto into display:inline-block can result in stretching the article over the blocks at the right when the article contains an image with a width greater than the width of the center column in the browser window.
on 2011-11-07 11:46
By phoenyx
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/22961?comment_id=46623 (commit 22961)
Use "r" order to reference changests. "#" is used to reference tickets.
r22960
r22960
on 2011-11-07 11:44
By phoenyx
view inline at https://app.assembla.com/spaces/impresscmsaddons/subversion/commits/22959?comment_id=46613 (commit 22959)
From an IPF point of view, this is not a good idea. Only dirname should have basename(dirname(__FILE__)) as a value. modname is a constant defined by the module developer and it shouldn't depend on a dynamic value. I would recomment to undo this change.