#972
  • Created on
    2009-12-17 10:04
  • Reported by
    lrbalt
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    epall
  • Milestone
    2.0
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

todo not updated when dependency added to dependency

in project view with one todo A. The todo has a dependency B. When I add a new todo and drag it on B, todo A is not updated to reflect change.

The resulting js should replace todo A with updated partial
User picture
  on 2010-02-10 14:01 *
By lrbalt
Assigned to set to epall
Summary changed from todo not updates when dependency added to dependency to todo not updated when dependency added to dependency
Assigned to set to epall
Summary changed from todo not updates when dependency added to dependency to todo not updated when dependency added to dependency
User picture
  on 2010-02-13 16:39 *
By epall
Status changed from New to Accepted
Status changed from New to Accepted
User picture
  on 2010-02-13 17:44 *
By epall
Assigned to changed from epall to lrbalt
Status changed from Accepted to New
Assigned to changed from epall to lrbalt
Status changed from Accepted to New
I'm finding it virtually impossible to write a Cucumber+Selenium test for this. I could throw it together in Selenium IDE in five minutes, but this whole Webrat thing confuses me.

Re-assigning to Reinier to write a test for this to show me how it's done.
User picture
  on 2010-02-15 11:20 *
By lrbalt
argh, you are asking me to do drag and drop?? I look into it
User picture
  on 2010-02-15 13:39 *
By epall
Drag and drop is actually not the hard part. You just say selenium.drag_and_drop_to_object, but all the stuff around it was messing me up, mostly figuring out the appropriate locators. I'm attaching the point that I got it to before getting irritated.
User picture
  on 2010-02-15 13:40 *
By epall
Attachment dragdrop_attempt.patch added
Attachment dragdrop_attempt.patch added
file:cFCqZIgJCr341yeJe5afGb
User picture
  on 2010-02-22 10:38 *
By lrbalt
I just committed a working feature. I'm not sure it does what you want. You drag-and-drop 3 onto 2, but two is ' hidden' since it is already a dependency. So I've changed it into 3 onto 1 for now.

If you do mean 3 onto 2, shouldn't you either go to the project page and drag-and-drop into 2 in the deferred/pending collection? Of you should expand todo 1 and drag and drop there?
User picture
  on 2010-02-22 12:24 *
By epall
You're the reporter, aren't you?
User picture
  on 2010-02-22 12:46 *
By lrbalt
ai, yes, so it seems :-) I was not very specific I see. I'll test it again...
User picture
  on 2010-02-22 14:10 *
By epall
Hahaha. Thus my avoidance :-)
User picture
  on 2010-03-02 10:19 *
By lrbalt
i just committed a working feature for this bug based on your patch. It took me a while to figure out that drag_and_drop does not wait for ajax to finish...

if you run the feature, the browser will stop and wait for Todo 3 to appear in the dependencies, but it will fail. If you reload, todo 3 will be there, so the ajax does not update Todo 1 to include Todo 3
User picture
  on 2010-03-02 10:20 *
By lrbalt
Assigned to changed from lrbalt to epall
Assigned to changed from lrbalt to epall
User picture
  on 2010-03-02 18:25 *
By epall
Status changed from New to Accepted
Status changed from New to Accepted
Awesome! I'll get on it.
User picture
  on 2010-03-06 23:58 *
By epall
Status changed from Accepted to Fixed
Work remaining changed from 1.0 to 0.0
Status changed from Accepted to Fixed
Work remaining changed from 1.0 to 0.0
(In revision:9591d29e7355ef02e14318442ab3de59d53fdb81) Fix refreshing of grandparent dependencies

Closes #972

Branch: master
User picture
  on 2010-03-08 09:14 *
By lrbalt
should you not traverse the grandparents recursively? I mean, if you have a deeper hierarchy, are the parents of the grandparents also updated?
User picture
  on 2010-03-08 15:24 *
By epall
Yeah, I should, but I was too lazy to figure out the algorithm.
User picture
  on 2010-03-08 15:57 *
By lrbalt
A little push and pop on a stack? :-)
User picture
  on 2010-03-09 04:59 *
By epall
Status changed from Fixed to New
Status changed from Fixed to New
okay, okay, you got me :-)
User picture
  on 2010-03-09 04:59 *
By epall
Status changed from New to Accepted
Status changed from New to Accepted
User picture
  on 2010-03-14 16:31 *
By epall
Status changed from Accepted to Fixed
Status changed from Accepted to Fixed
(In revision:a2f8327da4064cf5a74f8e5c3bd30b8390dd34e7) Correct walking of entire predecessor tree

Fixes #972

Branch: master