#923

Feedback ticket for action dependencies enhancement (ticket #903)

    • Created on: Sun, Jul 12 2009 (almost 3 years ago)
    • Reported by: maddentim
    • Assigned to: bohrax
    • Milestone: 2.0
    • Type: defect
    • Resolution: -
    • Version: git-devel
    • Status: Fixed
    • Priority: Normal (3)
    • Component: Functionality (app)
    • Estimate: None/Small/Medium/Large None
    • Severity: normal
    • Keywords: -
    This ticket is intended to track feedback for the action dependencies feature. See #300 and #903 for more details.

    Current issues



    • Ajax updates not working when removing successor of successor.
    • Tim Madden has reported that javascript gui updates when adding todos stops working after a while. This might or might not be connected to dependencies.
  • Followers
     
    Ico-users bohrax (Assigned To) , maddentim 
     
    Attachments
    Fico_general
    2.49 KB Added by lrbalt on July 18, 2009 00:50 UTC   Details
    Fico_general
    2.08 KB Added by lrbalt on August 04, 2009 01:14 UTC   Details
    Fico_general
    10.8 KB Added by lrbalt on August 05, 2009 07:02 UTC   Details
    Associations
     
    # Relation Summary Status Action
    Activity
     
    User picture

          on Jul 12, 2009 @ 07:50pm UTC * By bohrax

    Assigned to set to bohrax
    Thanks Tim for reporting this.

    I hope I have some time to look at this soon.
    User picture

          on Jul 12, 2009 @ 07:50pm UTC * By bohrax

    Status changed from New to Accepted
    User picture

          on Jul 14, 2009 @ 10:31pm UTC * By maddentim

    Great!

    Another thing I have noticed is that when typing in the dependencies text box, the autocomplete seems to pull from all possible actions, not just those that are not completed.
    User picture

          on Jul 18, 2009 @ 12:49am UTC * By lrbalt

    Milestone changed from Someday/Maybe to 1.8
    User picture

          on Jul 18, 2009 @ 12:50am UTC * By lrbalt

    Attachment make-toggle-work-after-drag-and-drop.diff added
    file:aQmrfACUer3R95eJe5aVNr: patch to make toggling work better after drag-and-drop
    User picture

          on Jul 18, 2009 @ 12:52am UTC * By lrbalt

    I've created a patch go get the toggling work better after drag-and-drop

    fixes predecessor not updated after drag-and-drop. And checks on source_view to not add successor to tickler if the page does not have a tickler
    User picture

          on Jul 20, 2009 @ 04:57am UTC * By bohrax

    This version should fix the following problems:
    • Pending todos not being activated correctly when completing from the mobile view.
    • Autocomplete matches against active todos in the current project. If no todos are found it searches all projects.
    • Crash on "New" from mobile view.
    • Added patch from Reinier that fixed toggling after DnD.
    User picture

          on Jul 20, 2009 @ 05:10am UTC * By bohrax

    The validation commit for preventing circular dependencies has a bug; when completing an action it loses its dependency information.
    User picture

          on Jul 21, 2009 @ 02:26am UTC * By maddentim

    Thanks Henrik,
    I pulled your changes into my tracks install and they fixed the mobile problem! I keep an eye on it the next few days and report any weirdness.
    User picture

          on Jul 29, 2009 @ 06:26am UTC * By maddentim

    Hi, You are likely already aware of this issue. I have pulled the latest changes in with a git pull (as of a couple hours back) and am having an issue when adding new todos. When I add one, it does not appear in the list. If I refresh the browser, it shows up. The form to add a todo stays on populated with the info for the todo you already added. (makes you tempted to add it again and then you get a dup!).
    User picture

          on Jul 29, 2009 @ 07:06am UTC * By maddentim

    Well, it seems to have corrected itself following a reboot for a new kernel... maybe something outside of tracks was causing the troubles. I went into to test it after Henrik emailed to say he had no heard of the problem. Before the reboot, I had restarted apache more than once and the problem continued. I knew it was fixed because the green flash message came on which (now that I think of it) was not sure before the report. I post again if I see the behavior come back.
    User picture

          on Aug 01, 2009 @ 12:11pm UTC * By maddentim

    The issue I was having on the 28th has returned... I tried restarting apache (which should restart passenger and tracks I would think) but to no avail. I imagine that rebooting might fix the problem again, but don't have the time now to do so. If any one has suggestions on how to troubleshoot the problem i would be willing to look around with some guidance. I am running it on a ubuntu server with RoR in apache2 with passenger.
    User picture

          on Aug 04, 2009 @ 01:14am UTC * By lrbalt

    Attachment reduce-db-access-on-autocomplete.diff added
    file:bDEkroGear3Q6yeJe5afGb: removes unneeded db calls and reduces data from db on auto complete
    User picture

          on Aug 04, 2009 @ 01:15am UTC * By lrbalt

    I've added a patch. I noticed on autocomplete that there is much db activity because of a prepend filter. Also reduces amount of fields that you retrieve to just the description.
    User picture

          on Aug 05, 2009 @ 07:02am UTC * By lrbalt

    Attachment improve_performance_and_ajax_removal_dependency.diff added
    file:aCa5Z4GtOr3RC9eJe5aVNr: this one includes previous patch
    User picture

          on Aug 05, 2009 @ 07:04am UTC * By lrbalt

    I've added a new patch. This one includes the previous (sorry)

    Besides one performance improvement, I've added the ability to remove a dependency. Seems to work for context and project view. Tag view needs work. Also multiple dependencies are not handles correct right now
    User picture

          on Aug 08, 2009 @ 08:36am UTC * By maddentim

    I switched back to the regular dev branch as error with the app getting stuck on the adding a new todo as first described here: http://www.assembla.com/spaces/tracks-tickets/tickets/923#comment:11

    I poked around but did not find a solution. The regular dev branch does not seem to hvae the problem. I was even thinking it was my web server. (Perhaps it is...)

    Tim
    User picture

          on Aug 11, 2009 @ 07:57pm UTC * By bohrax

    Description changed from Per Henrik's suggestion, I ... to This ticket is intended to ...
    Changed description to reflect the current feedback issues.

    Note: Reinier's patches are now included in the branch at git://github.com/bohrax/tracks.git
    User picture

          on Aug 17, 2009 @ 07:37am UTC * By maddentim

    Hello, the regular dev branch started getting stuck as described here: https://www.assembla.com/spaces/tracks-tickets/tickets/923-Feedback-ticket-for-action-dependencies-enhancement-(ticket--903)#comment:11

    I do not believe that the problem I am having is related to the action dependencies work. I will try to debug it as time permits and will let all know if I find the problem.
    User picture

          on Aug 26, 2009 @ 06:49pm UTC * By bohrax

    Description changed from This ticket is intended to ... to This ticket is intended to ...
    User picture

          on Aug 28, 2009 @ 12:35am UTC * By maddentim

    The javascript problem was self inflicted. I made a change to work around a bug in the mobile view, but while it fixed the mobile, it broke the javascript on the normal view. I will detail the problem on the original 801 ticket...
    User picture

          on Jan 18, 2010 @ 06:16am UTC * By epall

    Status changed from Accepted to Fixed
    Feels to me like we're set with dependencies. Great work, Henrik! If anybody wants to see changes to dependencies, please open a new ticket.
    Time Expenditure
    Loading