file:bb23EKmoGr3Ox_eJe5aVNr: CVS export failure

file:bchQN8moGr3Ox_eJe5aVNr: XML export failure

I've confirmed the second issue with xml export.

I think you missed a rake db:migrate during your upgrade to 1.7? This could be the explanation for the first error.

(In revision:a826fb9a11ed9ec7dce36aaf445f8646889f316c) improve data controller and fix #891 where the export of xml did not work because of the removal of tag.user_id

Branch: master

please reopen if the first error is not solved with a rake db:migrate

This was a new install of 1.7. Do I still need to run db:migrate? If so how do I specify a password?

Mark C.

Ran db.migrate. It ran without error but it made no difference. Both exports reported above still fail.

Regards,
Mark C.

I assume you got the 1.7.1devel code from github to try again? At least the xml export should work again?

I haven't had a chance to grab the development code and try. I will try in the next couple of days.

Regards,
Mark C.

ok, please try the fix first. It will probably fix one of the two exports.

The fix does correct the XML export. The CSV actions export still fails.

Regards,
Mark C.

Since I cannot reproduce, could you try the following?

In /path/to/tracks/app/controller/data_controller.rb replace the method csv_actions with this one

<codeblock>
def csv_actions
content_type = 'text/csv'
CSV::Writer.generate(result = "") do |csv|
csv << ["id", "Context", "Project", "Description", "Notes", "Tags",
"Created at", "Due", "Completed at", "User ID", "Show from",
"state"]
current_user.todos.find(:all, :include => [:context, :project]).each do |todo|

1. Format dates in ISO format for easy sorting in spreadsheet Print
2. context and project names for easy viewing

csv << [todo.id, todo.context.name,
todo.project_id.nil? ? "" : todo.project.name,
todo.description,
todo.notes, todo.tags.collect{|t| t.name}.join(', '),
todo.created_at.to_formatted_s(:db),
todo.due? ? todo.due.to_formatted_s(:db) : "",
todo.completed_at? ? todo.completed_at.to_formatted_s(:db) : "",
todo.user_id,
todo.show_from? ? todo.show_from.to_formatted_s(:db) : "",
todo.state]
end
end
send_data(result, :filename => "todos.csv", :type => content_type)
end
</codeblock>

hm, please ignore the <codeblock> and </codeblock>

Here is the original code:

  def csv_actions
    content_type = 'text/csv'
    CSV::Writer.generate(result = "") do |csv|
      csv << ["id", "Context", "Project", "Description", "Notes", "Tags",
        "Created at", "Due", "Completed at", "User ID", "Show from",
        "state"]
      current_user.todos.find(:all, :include => [:context, :project]).each do |todo|
        csv << [todo.id, todo.context.name, 
          todo.project_id = todo.project_id.nil? ? "" : todo.project.name,
          todo.description, 
          todo.notes, todo.tags.collect{|t| t.name}.join(', '),
          todo.created_at.to_formatted_s(:db),
          todo.due = todo.due? ? todo.due.to_formatted_s(:db) : "",
          todo.completed_at = todo.completed_at? ? todo.completed_at.to_formatted_s(:db) : "", 
          todo.user_id, 
          todo.show_from = todo.show_from? ? todo.show_from.to_formatted_s(:db) : "",
          todo.state] 
      end
    end
    send_data(result, :filename => "todos.csv", :type => content_type)
  end

When I insert the following:

def csv_actions
    content_type = 'text/csv'
    CSV::Writer.generate(result = "") do |csv|
    csv << ["id", "Context", "Project", "Description", "Notes", "Tags",
        "Created at", "Due", "Completed at", "User ID", "Show from",
        "state"]
    current_user.todos.find(:all, :include => [:context, :project]).each do |todo|
       csv << [todo.id, todo.context.name,
         todo.project_id.nil? ? "" : todo.project.name,
         todo.description,
         todo.notes, todo.tags.collect{|t| t.name}.join(’, ’),
         todo.created_at.to_formatted_s(:db),
         todo.due? ? todo.due.to_formatted_s(:db) : "",
         todo.completed_at? ? todo.completed_at.to_formatted_s(:db) : "",
         todo.user_id,
         todo.show_from? ? todo.show_from.to_formatted_s(:db) : "",
         todo.state]
        end
    end
    send_data(result, :filename => "todos.csv", :type => content_type)
end

It exits with a syntax error.

Ideas?
Mark C.

When I copy-and-pasted your code, my editor complained about the ', ' in the 11th line. Don't know why, but if you replace it with a single quote, a comma, a space and a closing single quote, it works for me.

OK, that did it. An output file is now generated.

Thanks,
Mark C.

Ok, thanks for testing it. I'll apply it for 1.7.1/1.8

(In revision:ceba3679421ed7fac4d018e861878e83dfd23a64) fix #891. Somehow the assignment causes an error for some people.

Don't know why though, but this fix is harmless anyway.

Branch: master

(In revision:a826fb9a11ed9ec7dce36aaf445f8646889f316c) improve data controller and fix #891 where the export of xml did not work because of the removal of tag.user_id

Branch: master

(In revision:ceba3679421ed7fac4d018e861878e83dfd23a64) fix #891. Somehow the assignment causes an error for some people.

Don't know why though, but this fix is harmless anyway.

Branch: master