#1100

move text out of application.js for i18n

    • Created on: Wed, Feb 09 2011 (over 1 year ago)
    • Reported by: lrbalt
    • Assigned to: lrbalt
    • Milestone: 2.0
    • Type: task
    • Resolution: -
    • Version: git-devel
    • Status: Fixed
    • Priority: Normal (3)
    • Component: User interface (js)
    • Estimate: None/Small/Medium/Large None
    • Severity: normal
    • Keywords: -
    • L49
    • L84
    • L321
    • L443, 451
    • L459
    • L484
    • L541
    • L568
    • L627
    • L792
  • Followers
     
    Ico-users lrbalt (Assigned To) 
     
    Attachments
    No attachments
    Associations
     
    # Relation Summary Status Action
    Activity
     
    User picture

          on Feb 09, 2011 @ 01:13pm UTC * By milgner

    Do you want to completely remove the text from the JavaScript or simply make it translatable using Babilu or such? If you like, I can take this on.
    User picture

          on Feb 09, 2011 @ 03:59pm UTC * By lrbalt

    I'd like to move as much as possible away from application.js. I still have some confirmation messages there which can be moved to the js that the server sends (AJAX). I think some text will remain and there we can look into Babilu. But it could be that we have just a handful, so a simple array/map could suffice too. Perhaps we could do Babilu for 2.1 and the array for 2.0?
    User picture

          on Feb 09, 2011 @ 06:28pm UTC * By lrbalt

    still left:
    • L49
    • L321
    • L489
    • L572
    • L792
    User picture

          on Feb 09, 2011 @ 06:33pm UTC * By lrbalt

    babilu seems unmaintained...
    User picture

          on Feb 09, 2011 @ 09:45pm UTC * By lrbalt

    Status changed from Accepted to Fixed
    (In revision:f2760ed7debe60bc70687e8118ecfc86efe7a8d3) fix #1101. Most strings were pushed into html attributes. The remaining are generated from the layout into an array
    User picture

          on Feb 09, 2011 @ 09:46pm UTC * By lrbalt

    the commit has wrong ticket number :-)

    Marcus, could you sync de.yml with my changes to en.yml?
    User picture

          on Feb 10, 2011 @ 12:14pm UTC * By milgner

    Will do!
    Time Expenditure
    Loading