#234

Allow other servlet filters to process response

    • Created on: Thu, Apr 07 2011 (about 1 year ago)
    • Reported by: Anonymous
    • Assigned to: -
    • Milestone: -
    • Estimate: None/Small/Medium/Large None
    • Status: New
    • Priority: Normal (3)
    • Component: -
    • Permission type: None
    I believe that the TemplateEngineFilter is currently swallowing the HTTP response, in that any other filters defined in web.xml after TemplateEngineFilter don't get a chance to process the response. Instead, the TemplateEngineFilter should call chain.doFilter(request_wrapper, response_wrapper).
  • Followers
     
    Ico-users 
     
    Attachments
    No attachments
    Associations
     
    No associations
    Activity
     
    User picture

          on Sep 09, 2011 @ 03:10pm UTC * By jstrachan

    Are you sure this is still an issue? If no template is found for a given URI then its calling chain.doFilter() - see

    https://github.com/scalate/scalate/blob/master/scalate-core/src/main/scala/org/fusesource/scalate/servlet/TemplateEngineFilter.scala#L87
    User picture

          on Sep 09, 2011 @ 03:20pm UTC * By dpinn

    Yes, that code looks good to me. It's ages since I ran into this, and
    it may well have been fixed in the meantime.

    On Fri, Sep 9, 2011 at 11:10 PM, James Strachan
    <scalate@alerts.assembla.com> wrote:
    > alert by James Strachan in space Scalate
    >
    > Comment (by James Strachan):
    >
    > Are you sure this is still an issue? If no template is found for a given URI
    > then its calling chain.doFilter() - see
    >
    > https://github.com/scalate/scalate/blob/master/scalate-core/src/main/scala/org/fusesource/scalate/servlet/TemplateEngineFilter.scala#L87
    >
    > More details
    >
    > Assembla | Knowledge, Tools, and Talent for agile teams
    Time Expenditure
    Loading