#29

[Bug] Init Tool 2.2.8 functionality

    • Created on: Sat, Jun 27 2009 (almost 3 years ago)
    • Reported by: Alicia86
    • Assigned to: sirebral
    • Milestone: 1.8.0 Release
    • Estimate: None/Small/Medium/Large None
    • Status: Fixed
    • Priority: Normal (3)
    • Component: Plugin
    • Permission type: None
    The Init Tool 2.2.8 commands aren't registering.
    /start
    /clear
    /list
    seem to function however the add commands:
    /add 12 name
    Name [1d20+2] init
    Don't seem to work.
    I have been unable to test the other commands without having added initiatives to the list.
  • Followers
     
    Ico-users sirebral (Assigned To) , Alicia86 
     
    Attachments
    No attachments
    Associations
     
    No associations
    Activity
     
    User picture

          on Jun 27, 2009 @ 11:17pm UTC * By sirebral

    You might try the Simple Init plugin. It has a GUI window that can show or hide itself. Also, In 1.7.9 Alpha, the plugin menu includes a little check box so that you hide or show the GUI even if you forget the text command.

    I have not used that tool, so I will take a look at it when I have some free time.
    User picture

          on Jun 27, 2009 @ 11:46pm UTC * By Alicia86

    I've tried Simple Init and if I recall correctly it doesn't have the feature I use the most, which is what I dub the round feature. Init Tool 2 can cycle through the initiative list with a simple command "nextinit" allowing the players to pass their turn when they are done.
    User picture

          on Jun 28, 2009 @ 04:37am UTC * By sirebral

    You might want to look again. Simple Init seems to work the same as Init 2.2.8. I have had reports of the printed text being pretty ugly and I can fix that. I will take a look at the Simple Init 2.2.8 when I have the time.
    User picture

          on Jun 28, 2009 @ 04:37am UTC * By sirebral

    Assigned to set to sirebral
    Milestone set to 1.7.9
    User picture

          on Jun 28, 2009 @ 07:29pm UTC * By Alicia86

    I took a look at it and here's the things which are different.
    Everything is controlled by the GM in Simple. From entering the initiatives to ending the players turn.
    The GM would have to go through ahead of time and enter the initiatives of the players and NPCs as with Init Tool 2 a message parse of "Alicia [1d20+6] init" could be used to set the initiative, which IMO is far less prep work as not only are the players able to roll their own initiatives but its an easy matter to add all the NPCs as well for the GM as you can do the "Alicia [1d20+6] init" or as the initiator of the plugin type the command "/add 12 NPC name".
    Also I tried saving the initiatives in Simple Init and then reloaded the program and they didn't save. Simple Init also froze ORPG after I had inserted the initiavtive of my 8 players into the window so I wasn't able to test it out completly.
    In Init Tool 2 the player at the end of their turn could type "nextinit" notifying the next person on the initiative order that it was now their turn. That was the main reason I liked Init Tool 2 as I have a nasty tendency of getting caught up in other things. The tool made the combat pacing faster as it essentially took out all my failings as a factor.

    I would really prefer it if someone would be able to fix Init Tool 2
    User picture

          on Jun 28, 2009 @ 07:58pm UTC * By Alicia86

    Here's a sample of how I use Init Tool 2. Battle Sample using Init Tool 2.2.8

    I tend to format the color and the italics out so it's not as colorful as you would see it on ORPG, but the purpose was to show how it worked.

    The players rolled their own initiatives with a text command of "Name [roll] init" which was recognized by the plugin.
    After their turn was complete they were able to say "nextinit" to indicate to the GM and their fellow players that their turn was done and the next person could then take their turn.
    User picture

          on Jun 28, 2009 @ 10:38pm UTC * By davidbyron

    If you don't mind sirebral I'll take this one; my GM uses that inittool. Actually I wondered if the mods I had made to it broke it but I see they have not been checked in so no. At any rate I'll need it fixed to get him to upgrade and I'm always better at bug fixes than new features.

    Also I tend to think if anyone actually bothers to go out of their way to log a bug here we should encourage that by giving it priority.
    User picture

          on Jun 28, 2009 @ 11:05pm UTC * By davidbyron

    Reproduced bug.

    The move from md5 to hashlib is the culprit. I have given the customer the old file with md5 but a real bug fix needs to use hashlib.
    User picture

          on Jun 28, 2009 @ 11:22pm UTC * By davidbyron

    Status changed from New to Test
    Looks like the problem was how to call the md5 under the new library.

    replaced "m = hashlib.new()" with 'm = hashlib.md5()"

    seems to work now using the hashlib library. file about to be uploaded.
    User picture

          on Jun 28, 2009 @ 11:23pm UTC * By davidbyron

    Attachment xxinit2.py added
    User picture

          on Jun 29, 2009 @ 12:16am UTC * By davidbyron

    Wasn't there another place we switched to hashlib?
    User picture

          on Jun 29, 2009 @ 01:55am UTC * By sirebral

    yeah. Do you have an old 1.7.1 zip? Chris does on the site and I think there is one here. You can run that with the debug window and it will spit out the errors and lines.

    BTW, thanks David!
    User picture

          on Jun 29, 2009 @ 04:07am UTC * By davidbyron

    In have 1.7.1,1.7.5, 1.7.6, 1.7.7, 1.7.8 and 1.7.9 installed :)

    It's in CherryPy.

    I was looking at the code when the customer had an issue with the fix I sent her being overwritten by the auto-upgrade. We tried several things before I suggested she simply make the file read-only. That makes the upgrade abort and then the program carried on. We tried using start_noupdate and tried the -n parameter and the file was still changed. I think fixing the updater needs to be a priority so that people will not be worried about updating. I need to be able to issue a hotfix without it being wiped out by the auto-update. roll-back would be very nice. A dialog with "Here's what's changed, you want it? Yes/No" would be nice. The developer vs release check-outs would be nice. All the old stuff in fact.

    Anyway CherryPy: the line,

    "hashlib.hashlib(s).hexdigest()"

    should probably be, "hashlib.md5(s).hexdigest()" or "hashlib.sha1(s).hexdigest()"

    but the I got thinking about the fact that its third party code and we've missed about 5 years worth of updates to it. CheryPy is a full web server -- I don't know if it was in 2004.

    Anyway I've never tried CherryPy so I will have to try to get it working in an older version before seeing if it is in fact going wrong now.
    User picture

          on Jun 29, 2009 @ 05:51am UTC * By sirebral

    md5 was deprecated too. And what is with OFF TOPIC Cherry Py argument here?
    User picture

          on Jun 29, 2009 @ 06:27am UTC * By sirebral

    Duh me. Now I see. sorry David, didn't mean to step on your toes. I just saw CherryPy and thought => I started that over there ...
    User picture

          on Jul 05, 2009 @ 06:49am UTC * By sirebral

    Status changed from Test to New
    Set back to new. The /addfx command is not working.
    User picture

          on Jul 16, 2009 @ 06:22am UTC * By davidbyron

    /addfx is working for me. the format is /addfx number number phrase
    User picture

          on Jul 27, 2009 @ 12:02am UTC * By Digitalxero

    Milestone changed from 1.7.9 to Current Release
    Summary changed from Init Tool 2.2.8 functionality to [Bug] Init Tool 2.2.8 functionality
    User picture

          on Jul 28, 2009 @ 04:47am UTC * By davidbyron

    Status changed from New to Test
    So I'm setting this back to "Test" if you don't have anything more on that /addfx thing.....?
    User picture

          on Aug 08, 2009 @ 06:19pm UTC * By davidbyron

    Status changed from Test to Fixed
    Alright closing as fixed. I know one customer with it running OK.
    User picture

          on Aug 17, 2009 @ 01:56am UTC * By Digitalxero

    Milestone changed from Current Release to 1.8.0 Release
    Updating tickets (#49, #38, #59, #60, #84, #10, #20, #23, #27, #29, #52, #58, #68, #72, #74, #75, #76, #77, #86, #87, #31, #57, #85)
    Time Expenditure
    Loading