#10

Loading Maps with Minis in place locks up OpenRPG

    • Created on: Fri, Jun 13 2008 (almost 4 years ago)
    • Reported by: -
    • Assigned to: -
    • Milestone: 1.8.0 Release
    • Estimate: None/Small/Medium/Large None
    • Status: Fixed
    • Priority: Normal (3)
    • Component: -
    • Permission type: None
    In the current release (after you download from openrpg.com and then do an update. This issue does not occur if you don't do an update) If you create a map with a set of miniatures the map will lock up openrpg on load. I've tested this on both Linux and Windows. Maps without miniatures load fine. The maps have been created in the same version of OpenRPG that the locks happen.

    I can do some strange tricks to get a map to load. For example if I edit the file, remove all but one miniature the map will load, then I can edit the file and add back miniatures one at a time and the map will load but if I add more than one miniature definition back at a time openrpg will lock. After I've added each icon back in one by one (via text editor) and have the map loaded I've resaved the map, exited and reloaded openrpg, tried to open the map and openrpg locks trying to load.

    I code perl but not python well enough to sift through this. My random guess is that the icons are trying to load simultaneously rather than in series and are conflicting on a file lock or some other piece. Again just my random guess.

    [peter@localhost OpenRPG-Data]$ cat Burial-Site.xml
    <nodehandler class="min_map" icon="compass" module="core" name="miniature Map">
    <map version='2.1' sizex='879' sizey='620' action='new'>
    <miniatures serial='1'>
    <miniature action='new' label='' id='mini-0-60' posx='560' posy='298' heading='0' face='0' path='http://dnd/D-icon.jpg' locked='0' hide='0' align='0' zorder='0' width='0' height='0' />
    <miniature action='new' label='' id='mini-0-62' posx='557' posy='242' heading='0' face='0' path='http://dnd/D-icon.jpg' locked='0' hide='0' align='0' zorder='1' width='0' height='0' />
    <miniature action='new' label='' id='mini-0-65' posx='498' posy='145' heading='0' face='0' path='http://dnd/R-icon.jpg' locked='0' hide='0' align='0' zorder='3' width='0' height='0' />
    <miniature action='new' label='' id='mini-0-66' posx='496' posy='90' heading='0' face='0' path='http://dnd/R-icon.jpg' locked='0' hide='0' align='0' zorder='4' width='0' height='0' />
    <miniature action='new' label='' id='mini-0-67' posx='409' posy='149' heading='0' face='0' path='http://dnd/R-icon.jpg' locked='0' hide='0' align='0' zorder='5' width='0' height='0' />
    <miniature action='new' label='' id='mini-0-68' posx='349' posy='210' heading='0' face='0' path='http://dnd/R-icon.jpg' locked='0' hide='0' align='0' zorder='6' width='0' height='0' />
    <miniature action='new' label='' id='mini-0-69' posx='352' posy='150' heading='0' face='0' path='http://dnd/S-icon.jpg' locked='0' hide='0' align='0' zorder='7' width='0' height='0' />
    <miniature action='new' label='' id='mini-0-70' posx='261' posy='150' heading='0' face='0' path='http://dnd/P-icon.jpg' locked='0' hide='0' align='0' zorder='8' width='0' height='0' />
    <miniature action='new' label='' id='mini-0-71' posx='174' posy='148' heading='0' face='0' path='http://dnd/H-icon.jpg' locked='0' hide='0' align='0' zorder='9' width='0' height='0' />
    </miniatures>
    <bg color="#008040" path="http://dnd/Burial-Site.jpg" type="2" local="True" localPath="/home/peter/DnD-Tuesday-Game/OpenRPG-Data/KoboldAmbush.jpg" localTime="-1"/>
    <grid color='#000000' size='100' ratio='2.0' snap='0' mode='0' line='0'/>
    <fog>
    <poly action="del" outline="all"/>
    </fog>
    </map>
    </nodehandler>
  • Followers
     
    Ico-users 
     
    Attachments
    No attachments
    Associations
     
    No associations
    Activity
     
    User picture

          on Jun 13, 2008 @ 02:55pm UTC * By Anonymous

    • *attachment* Burial-Site-cleaned.xml added
    User picture

          on Jun 13, 2008 @ 03:48pm UTC * By

    Ok I can confirm now that if I replace the load_img sub in images.py with the code from the older release the loading of maps will work. I'll attach the patch to cycle back. I can see that code needs some modifications because it frequently fails to load an image and leaves the fetching icon. "refresh minatures' will resolve that issue.

    I'll continue to try to figure out what the actual problem with the images.py is and fix that.
    User picture

          on Jun 13, 2008 @ 03:51pm UTC * By Anonymous

    • *attachment* images.py.patch added
    User picture

          on Jun 13, 2008 @ 05:01pm UTC * By sirebral

    Uh... The actual problem is that you are probably using version 1.7.5 which was quickly updated because of that problem. Download the installer from this page and then you can update to 1.7.7 and run maps with minis just fine.
    User picture

          on Jun 13, 2008 @ 05:12pm UTC * By sirebral

    Also, your Burial XML isn't going to prove useful because I don't know where you are getting those images from. If i could get the URL or at least a neutral URL to show you that 1.7.7 works, you would see that you don't need to edit that info.

    One other thing. While you maybe able to get the images to work in 1.7.5, you probably won't have the full capability of OpenRPG anymore. Another argument is being passed which allows users to drag and drop their minis; which I think was the cause of all of the problems. And unless everyone is using 1.7.7 then you are going to be faced with two problems. The first problem will be the Map getting eaten every time a Miniature is moved with Click - Drop. The second problem will be a serious amount of errors that you will see in the Terminal or Debuggers screen; causing a lot of processing congestion.
    User picture

          on Jun 15, 2008 @ 09:17pm UTC * By

    Status changed from New to Fixed
    Thanks, I did notice the map getting over eaten issue. Other maps (or previous maps would be loaded). I didn't expect my solution to be the right one, I was just hoping it would help debug if the problem wasn't resolved. The OpenRPG Base package seemed to do the trick for me.
    User picture

          on Jun 15, 2008 @ 10:12pm UTC * By sirebral

    No problem, *. I am here to help. It has been requested on the Forums that the OpenRPG page's download link be updated. That has been a problem with new users, unfortunately.
    User picture

          on Aug 16, 2009 @ 11:56pm UTC * By Digitalxero

    Milestone changed from Current Release to 1.8.0 Release
    Updating tickets (#49, #38, #59, #60, #84, #10, #20, #23, #27, #29, #52, #58, #68, #72, #74, #75, #76, #77, #86, #87, #31, #57, #85)
    Time Expenditure
    Loading