#96

Unique Bags and Trading of Bags

    • Created on: Fri, Nov 11 2011 (7 months ago)
    • Reported by: Pilus
    • Assigned to: Dathil
    • Milestone: GHI v.1.99.4
    • Work remaining: 8.0 hours
    • Type: Bug
    • Depends on ticket(s): -
    • Status: Accepted
    • Priority: Normal (3)
    • Component: Renovated Containers
    • Permission type: Private
    • Bug detected in Version: -
    • Technical Difficulty: Medium
    (The following conversation sums up the problem. The chosen solution can be seen in a comment to this ticket)
    Pilus: I have realised that trading of bags are a bit of a design nightmare, because we now allow any item to open any bag. I mean any instance of the item.So if you have two items in a stack, give it a bag action and then split the item into two, they still open the same bag. The problem is then if you trade one of them away, what happens with the bag content?

    Aurora: i know it did that before and we had to empty the bag..perhaps if we somehow checked if the bag was full then flagged it in som fashion?
    Pilus: You mean so we wont allow to trade any bags with content?
    Aurora: well that or we flag the bag to say 'hey i have content in me now i need to make myself some kind of indepentent enity/instance of the other empty bag like me' or provide a copy all items in bag on trade option.
    Pilus: hmm, yeah. We could do that by putting some kind of limit to how many items there are allowed in each item instance, but that can also easily confuse the user if the got a whole stack of items that are a bag.
    Aurora: yeah and if we could somehow make an affix to its ID when it has content in it so its like you have two diffrent bags like empty. Like a bag instanceID that could be changed on the code in depending on if the bag has items or not. so in a way you can check for it and treat them like psudeo seprate instances of themselves
    Pilus: An alternative solution is to always trade the related bag. That might be needed to be shown as a text in the trade frame to notify the trading user about it
    Aurora: that other solution works too.
  • Followers
     
    Ico-users Dathil (Assigned To) , Pilus 
     
    Attachments
    No attachments
    Associations
     
    No associations
    Activity
     
    User picture

          on Nov 29, 2011 @ 10:11pm UTC * By Pilus

    Status changed from New to Accepted
    A more simple solution:
    In the "Bag" action menu, the user can check "Tradeable Bag". This results in the following:
    • The item is locked into having a Stacksize of 1.
    • In the create / edit item menu the stacksize slider is clocked
    • If there is already items of these existing: Whenever they are splitted into smaller stacks, they can not merge again, as the stacks will try to get a stack size of 1.
    • On first use, the "bag" action will result in the evt. old bag becomes tied to one item instance. The old bagGuid is given as an attribute to this item instance.
    • On use with other items instances, they get a new bagGuid to their item instance, if they do not have already
    • When an item instance is split, the split off instance is given the original bag guid and the remaining gets a new guid. This ensures that the bag will be traded, in the case of a user editing a stack of bags to be tradeable, right before giving them away.
    User picture

          on Dec 06, 2011 @ 10:18pm UTC * By Pilus

    Description changed from Pilus: I have realised that... to Pilus: I have realised that...
    Milestone changed from GHI v.1.99.1 to GHI v.1.99.2
    User picture

          on Dec 26, 2011 @ 04:56pm UTC * By Pilus

    Description changed from Pilus: I have realised that... to (The following conversation...
    User picture

          on Apr 07, 2012 @ 06:56pm UTC * By Pilus

    A solution for bags and advanced items:

    • The action identify the container using an attribute of the type 'GUID'
    • When choosing a bag for the dynamic action to interact with the play can then select an attribute of the type 'GUID'.
    • The instances with this attribute should have a max size of 1

    This might requires some changes to how selecting of attributes is done. E.g. so you can only select those attribute types that fits the input in type.
    User picture

          on Apr 07, 2012 @ 10:57pm UTC * By Pilus

    Maybe the same can be used on simple / standard items.
    Currently it is done by using attributes a bit in the same way. Only change this requires is for attributes to be part of the item data for simple items.
    In this way all the bag action just needs to add the "bagX" attribute of type 'GUID' to the item.
    User picture

          on Apr 07, 2012 @ 10:59pm UTC * By Pilus

    Milestone changed from GHI v.1.99.2 to GHI Backlog
    User picture

          on Apr 30, 2012 @ 10:34am UTC * By Dathil

    Assigned to set to Dathil
    Status changed from Accepted to In Progress
    User picture

          on Apr 30, 2012 @ 10:49am UTC * By Dathil

    Status changed from In Progress to Accepted
    User picture

          on Apr 30, 2012 @ 01:50pm UTC * By Pilus

    Milestone changed from GHI Backlog to GHI v.1.99.4
    Updating tickets (#96, #111, #112, #131, #132, #133, #134, #139, #141, #146, #147, #155)

    Moved to current sprint.
    Time Expenditure
    Loading