#101

Addition of Official/Custom sorting for Icon Picker

    • Created on: Thu, Jan 05 (5 months ago)
    • Reported by: Katecia
    • Assigned to: Katecia
    • Milestone: GHI v.1.99.2
    • Bug detected in Version: -
    • Technical Difficulty: Medium
    • Status: Fixed
    • Priority: Lowest (5)
    • Component: GHM Window
    • Permission type: Private
    • Type: Improvement
    • Depends on ticket(s): -
    Just a minor thought I had. As it stands, it's very difficult to tell what icons are custom GHI icons, which seems like it leads to them getting used less. If we could make a sorting option for the icon picker to show all icons, just official icons, or just GHI icons, people could easily see what icons are unique to GHI, and would therefore stand out against other items in their bags.
  • Followers
     
    Ico-users Katecia (Assigned To) , Pilus 
     
    Attachments
    No attachments
    Associations
     
    No associations
    Activity
     
    User picture

          on Jan 05, 2012 @ 11:57pm UTC * By Pilus

    I agree in it, as it is hard to spot the unique GHI icons.
    User picture

          on Jan 08, 2012 @ 07:08pm UTC * By Pilus

    Status changed from New to Accepted
    User picture

          on Jan 11, 2012 @ 07:32am UTC * By Katecia

    Status changed from Accepted to In Progress
    I did some work towards this goal today. It's basically ready - There's a value named showIconType in ghm.lua now that does this, but I'm not familiar enough with the XML of the icon picker to add a UI element for it. If someone else wants to add that in, it would be greatly appreciated.

    I also made some other tweaks to the code that are mentioned in the commit notes.
    User picture

          on Jan 11, 2012 @ 10:27am UTC * By Pilus

    Assigned to set to Pilus
    Looks good. I will implement the UI element for it.
    User picture

          on Jan 13, 2012 @ 07:31pm UTC * By Pilus

    (In revision:595) re #101. I have implemented a drop down menu for it as well as a function, GHM_SetShownIconType, for setting the variable.
    User picture

          on Jan 13, 2012 @ 07:37pm UTC * By Pilus

    Assigned to changed from Pilus to Katecia
    User picture

          on Jan 15, 2012 @ 12:42am UTC * By Pilus

    The categories seems to have broken though. Changing categories are not effecting the icons shown.
    User picture

          on Jan 23, 2012 @ 10:27pm UTC * By Katecia

    Status changed from In Progress to Ready for Test
    The categories should be fixed now. Let me know if I managed to break it in some other fancy way.
    User picture

          on Jan 25, 2012 @ 09:40pm UTC * By Pilus

    Status changed from Ready for Test to Fixed
    Great. It works!
    Time Expenditure
    Loading