#595

Missing element titles for use in automated testing

    • Status: Fixed
    • Priority: Normal (3)
    • Component: -
    • Estimate: None/Small/Medium/Large None
    • type of feature: -
    • Fixed in: -
    Ensure names are applied to all elements e.g. buttons, for easier tracking in automated tests. Some elements currently without names are:

    • "Send File", "Guest invite", "My Files", "Help", "About" and "Logoff" buttons across top (although these used to have link names)
    • titles adjacent to fields (e.g. To, From, Subject, Message, Expiry Date, Select your file) for uploading a file (authenticated and using voucher) and adding new recipient (for these so far I've been verifying that the text is present rather than the element itself)
    • "Cancel" button in Help and About
    • "Send" and "Cancel" buttons when adding new recipient
    • "Cancel" and then subsequent "Cancel" and "OK" buttons, when cancelling an upload during progress
    • "Show/Hide" AUP option (when both showing and hiding)
    • descriptive text below "Guest invite" heading
    • "Send Voucher" button
  • Followers
     
    Ico-users Wendy Mason (Assigned To) , gijzelaerr , ricoshae 
     
    Attachments
    Fico_zip
    794 KB Added by ricoshae on December 28, 2011 00:28 UTC   Details
    Associations
     
    # Relation Summary Status Action
    Activity
     
    User picture

          on Nov 25, 2011 @ 08:40am UTC * By Wendy Mason

    Assigned to changed from wendy_mason to ricoshae
    User picture

          on Dec 14, 2011 @ 05:46am UTC * By ricoshae

    When you say "names" do you mean alt='logon" type tag or name='logon' tag.
    And is this only for images as the menu items are now css created so the wording on the link is real text.
    User picture

          on Dec 14, 2011 @ 06:17am UTC * By Wendy Mason

    Hmmm. My guess would actually be id='logon' or link='logon'. Whatever equates to, for example, id=fileto for the recipient email address field. This applies to everything (buttons, text, fields, any other links). If you take a glance at one of the test scripts in http://www.assembla.com/code/file_sender/subversion/nodes/workflowtests/selenium_IDE, anything where an option like "click", "clickAndWait", "type", "[...]ElementPresent", "[...]ElementNotPresent", "verifyValue", "verifyChecked" or "verifyText" (but not "verifyTextPresent" or "verifyTextNotPresent") is followed by an element name (rather than "css=something" or "//div[...]") Selenium can already identify uniquely.
    User picture

          on Dec 28, 2011 @ 12:26am UTC * By ricoshae

    Status changed from New to Test
    (In revision:1119) test #595 Missing element id's added for use in automated testing
    User picture

          on Dec 28, 2011 @ 12:28am UTC * By ricoshae

    Attachment id_filesender_screens.zip added
    file:ckfWSMmoir4zV9acwqjQYw: Screen shots with ID locations MD5: dc7b2e1f5608d90fb8f0fbc53bdaf44f
    User picture

          on Dec 28, 2011 @ 12:29am UTC * By ricoshae

    Attached screenshots with ID names for future reference
    User picture

          on Feb 28, 2012 @ 12:03pm UTC * By Xander Jansen

    Wendy, can you confirm that the current way is sufficient for the automated testing?
    User picture

          on Mar 02, 2012 @ 04:41am UTC * By Wendy Mason

    Status changed from Test to Accepted
    Most element titles are now appearing and working :). These make the test scripts much more robust now :). The annotated screenshots Chris attached were really useful, so thanks also to Chris for taking the time to create these! One set of elements that still don't have titles however is the text to the left of fields ("From:", Subject:", "Message:", "Expiry date:" etc.), which for now I'm verifying in the scripts as text rather than as an element containing expected text (except for "To:", see below). A couple of anomalies that came up when working on the scripts (using 1.5-beta1 at preview installation) are:
    • "To:" or "Send Vouchers to:" to the left of "fileto" fields - css=td.mandatory (which I'm using for the moment).
    • decriptive text across the top of the Guest invite page - css=td
    User picture

          on Mar 12, 2012 @ 02:48am UTC * By Wendy Mason

    Another set of elements without titles is most of the headers to the "My Files" table (except "To"), i.e. "From", "File name", "Size", "Subject", "Message", "Created" and "Expiry".
    User picture

          on Mar 12, 2012 @ 03:04am UTC * By Wendy Mason

    Another anomaly ... the element titles for the action buttons in the "My Files" table are all appended with "_1" (and aren't recognised by Selenium IDE without this) e.g. "btn_resendemail_1". This does not affect running the tests, it's just something that differs slightly from the nice annotated screenshots Chris supplied :).
    User picture

          on Mar 12, 2012 @ 09:03am UTC * By Xander Jansen

    The '_1' numbering was introduced in revision:1129 to make valid (W3C compliant) pages. The ID attribute has to be unique per page. We could also use the 'class' attribute (additionally) which does not need to be unique if that would help with the scripting. Care should be taken though with the CSS definitions when doing that.
    User picture

          on Mar 13, 2012 @ 02:22am UTC * By Wendy Mason

    The '_1' numbering does not affect test scripting, so there are no issues with leaving these as they are in this respect.
    User picture

          on Mar 16, 2012 @ 12:36am UTC * By ricoshae

    Status changed from Accepted to Test
    (In revision:1267) test #595 added mising id's for upload titles and myfiles table header
    User picture

          on Mar 16, 2012 @ 12:37am UTC * By ricoshae

    Upload titles:
    upload_to
    upload_from
    upload_subject
    upload_message
    upload_expirydate

    My files header:
    myfiles_header_to
    myfiles_header_from
    myfiles_header_filename
    myfiles_header_size
    myfiles_header_subject
    myfiles_header_message
    myfiles_header_created
    myfiles_header_expiry
    User picture

          on Mar 16, 2012 @ 06:42am UTC * By Wendy Mason

    Status changed from Test to Accepted
    Thanks Chris :). These all work (although myfiles_header_to isn't detected by Selenium-IDE in the same way as the other "My FIles" header element titles). I've also realised that we could do with some element titles for the vouchers table too ;), which for now I'm detecting as text. Could you also please (as detailed in an earlier comment) set element titles for:
    • "Send Vouchers to:" to the left of "fileto" fields (currently css=td.mandatory)
    • descriptive text across the top of the Guest invite page (currently css=td)
    User picture

          on Mar 18, 2012 @ 12:44pm UTC * By ricoshae

    Status changed from Accepted to Test
    (In revision:1284) test #595 Added extra id tags for selenium to vouchers.php
    User picture

          on Mar 18, 2012 @ 12:45pm UTC * By ricoshae

    Revision:1284

    Vouchers:
    vouchers_to
    vouchers_expirydate

    vouchers_header_to
    vouchers_header_created
    vouchers_header_expiry

    invite_text
    User picture

          on Mar 18, 2012 @ 12:46pm UTC * By ricoshae

    (In revision:1284)

    Vouchers:
    vouchers_to
    vouchers_expirydate

    vouchers_header_to
    vouchers_header_created
    vouchers_header_expiry

    invite_text
    User picture

          on Mar 20, 2012 @ 04:39am UTC * By Wendy Mason

    Status changed from Test to Fixed
    Great, thanks :).
    User picture

          on Apr 03, 2012 @ 11:38am UTC * By Wendy Mason

    Status changed from Fixed to Accepted
    Inthe "Add new recipient" popup, the "Send" and "Cancel" buttons used to have element titles but these seem to now be missing. These were btn_addrecipientsend and btn_addrecipientcancel.
    User picture

          on Apr 03, 2012 @ 11:40am UTC * By Wendy Mason

    Status changed from Accepted to Fixed
    Please orget the last comment ... they are working again now :).
    User picture

          on Apr 30, 2012 @ 10:24am UTC * By Wendy Mason

    Status changed from Fixed to Accepted
    One more set I missed before ... in the "Add new recipient" popup, while the fields have element titles their names (the text to the left of the fields) do not appear to: "To:", "From:", "Subject: (optional)", "Message: (optional)", "Expiry date:", "File to be redistributed:" and "Size:".
    User picture

          on May 01, 2012 @ 02:32am UTC * By ricoshae

    Added as:
    files_to
    files_from
    files_subject
    files_message
    files_expiry
    files_to_be_resent
    files_size
    User picture

          on May 01, 2012 @ 02:32am UTC * By ricoshae

    Status changed from Accepted to Test
    (In revision:1399) test #595 add missing elements
    User picture

          on May 01, 2012 @ 02:33am UTC * By ricoshae

    Assigned to changed from ricoshae to wendy_mason
    User picture

          on May 02, 2012 @ 11:29am UTC * By Wendy Mason

    Status changed from Test to Fixed
    Looks great! Many thanks :).
    User picture

          on May 06, 2012 @ 08:14pm UTC * By Xander Jansen

    (In revision:1440) Merge r1399 re #595 add missing elements
    User picture

          on May 08, 2012 @ 06:19am UTC * By Wendy Mason

    Assigned to changed from wendy_mason to ricoshae
    Status changed from Fixed to Accepted
    A few more ... all text (within the border) and the "Start Download" button on the Download page. This can wait until after beta3.
    User picture

          on May 08, 2012 @ 08:52am UTC * By ricoshae

    Assigned to changed from ricoshae to wendy_mason
    Whats alt text (within the border) ?
    User picture

          on May 08, 2012 @ 08:59am UTC * By Wendy Mason

    For the Download page, missing element titles are for the following titles (e.g. "To:") and each of the values to their right (e.g. email address of recipient): "To:", "From:", "Subject: ", "Message:", "File Name:", "File Size:", "Expiry date:". Also the "Start Download" button (the page heading is fine).
    User picture

          on May 08, 2012 @ 09:24am UTC * By ricoshae

    yes - of course.
    User picture

          on May 08, 2012 @ 09:24am UTC * By ricoshae

    Assigned to changed from wendy_mason to ricoshae
    User picture

          on May 08, 2012 @ 09:37am UTC * By ricoshae

    Status changed from Accepted to Test
    (In revision:1462) test #595 - added id tags
    User picture

          on May 08, 2012 @ 09:38am UTC * By ricoshae

    (In revision:1463) test #595 - typo fixed
    User picture

          on May 08, 2012 @ 09:40am UTC * By ricoshae

    Assigned to changed from ricoshae to wendy_mason
    labels
    download_to
    download_from
    download_subject
    download_message
    download_filename
    download_filesize
    download_expiry

    File information
    to
    from
    subject
    message
    filename
    filesize
    expiry
    User picture

          on May 08, 2012 @ 12:00pm UTC * By Wendy Mason

    Assigned to changed from wendy_mason to ricoshae
    Status changed from Test to Accepted
    Element titles look great for the Download page except for "message", which is detected as "//td[@id='message']" and which may also be the culprit for new ticket #728.
    User picture

          on May 08, 2012 @ 02:27pm UTC * By ricoshae

    Assigned to changed from ricoshae to wendy_mason
    changed message to filemessage
    User picture

          on May 09, 2012 @ 01:10am UTC * By Wendy Mason

    Status changed from Accepted to Test
    User picture

          on May 09, 2012 @ 01:17am UTC * By Wendy Mason

    Status changed from Test to Fixed
    Element titles on the Download page all look great now, thanks :).
    User picture

          on May 09, 2012 @ 03:07pm UTC * By Xander Jansen

    (In revision:1473) Merge r1460,1462-1463,1465 re #595 download page element id's
    Time Expenditure
    Loading