Arrow_left   Arrow_right
 
  #4

Purge removed libraries from load_all.clj

    • Status: Fixed
    • Priority: Normal (3)
    • Component: -
    • Permission type: None
    (load "clojure/contrib/load_all") has not worked since the penultimate commit to clojure-contrib, as libraries are being moved to core. all-contrib-libs needs to be adjusted to match the new set of libraries.
  • Followers
     
    Ico-users stuart.halloway (Assigned To) , hircus 
     
    Attachments
    Fico_general
    1.52 KB Added by hircus on Jul 01 20:58 2009 UTC   Details
    Associations
     
    No associations
    Activity
     
    User picture

          on Jul 01, 2009 @ 08:58PM UTC * By hircus

    Attachment load_all.diff added
    file:c6XnLWzMGr3QkbeJe5aVNr: git-generated diff to load_all.clj
    User picture

          on Jul 01, 2009 @ 09:01PM UTC * By Steve Gilardi

    If it's feasible, it would be good to add load-all to the tests that are run by "ant test" so it gets run frequently. (I run ant test every time I build clojure and contrib.)
    User picture

          on Jul 10, 2009 @ 08:44PM UTC * By Steve Gilardi

    In case somebody likes this idea gets to this before I do: I think it would be cool for load-all to figure out what all the clojure-contrib libraries are on its own: perhaps by searching in the resources in the clojure-contrib Jar file for ns declarations that are exactly "clojure.contrib.[^.]+$" (only one component after clojure.contrib).

    We could then maintain a list in the load-all vicinity of only those libraries that should not be loaded by load-all. That seems much easier to maintain as we'll automatically be prompted (by a failure to load) if we forget an exclusion.
    User picture

          on Jan 31, 2010 @ 05:33AM UTC * By stuartsierra

    Milestone set to Backlog
    Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)
    User picture

          on Apr 13, 2010 @ 03:21PM UTC * By stuart.halloway

    Assigned to set to stuart.halloway
    Milestone changed from Backlog to Release 1.2
    User picture

          on Apr 13, 2010 @ 05:06PM UTC * By stuart.halloway

    Status changed from New to Fixed
    Here's the approach I took:

    • moved the file from main to test
    • used find-namespace to find all the namespaces
    • removed the deprecated ones
    • manufactured one unit test per namespace that tries to load the namespace
    Time Expenditure
    Loading